Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix market swap handler to properly treat zero spread case #336

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Apr 8, 2020

Summary of changes

Current market handler crash when it meets zero tobin tax denom(not possible, under columbus-3). This release will prevent crash for the swap between zero tobin tax denoms.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Apr 8, 2020
@yun-yeo yun-yeo added bug Something isn't working daemon daemon updates labels Apr 8, 2020
@yun-yeo yun-yeo requested a review from dokwon April 8, 2020 13:27
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #336 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #336      +/-   ##
===========================================
+ Coverage    71.26%   71.29%   +0.02%     
===========================================
  Files           75       75              
  Lines         3644     3647       +3     
===========================================
+ Hits          2597     2600       +3     
  Misses         901      901              
  Partials       146      146              

Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokwon dokwon merged commit d8586be into develop Apr 8, 2020
@dokwon dokwon deleted the bugfix/allow-zero-tobin-tax branch April 8, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working daemon daemon updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants