Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Oracle Slashing #340

Merged
merged 1 commit into from
Jun 1, 2020
Merged

[Bugfix] Oracle Slashing #340

merged 1 commit into from
Jun 1, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Apr 25, 2020

Summary of changes

  • Check bonded & jailed status before oracle slashing

close #341

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added bug Something isn't working daemon daemon updates labels Apr 25, 2020
@yun-yeo yun-yeo requested a review from dokwon April 25, 2020 03:03
@yun-yeo yun-yeo self-assigned this Apr 25, 2020
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #340 into develop will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #340      +/-   ##
===========================================
+ Coverage    71.38%   71.42%   +0.03%     
===========================================
  Files           75       75              
  Lines         3649     3653       +4     
===========================================
+ Hits          2605     2609       +4     
  Misses         899      899              
  Partials       145      145              

@dokwon
Copy link
Contributor

dokwon commented Jun 1, 2020

@YunSuk-Yeo did this not get released already in v0.3.5?

@yun-yeo
Copy link
Contributor Author

yun-yeo commented Jun 1, 2020

@dokwon Yes already fixed but it is not merged on develop branch. only master and v0.3.5 has that change

@dokwon dokwon merged commit d23749c into develop Jun 1, 2020
@hanjukim hanjukim deleted the bugfix/oracle-slash branch June 29, 2020 04:07
tuky191 pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working daemon daemon updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] oracle slashing of unbonded validator
2 participants