Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support old-hd-path flag #349

Merged
merged 1 commit into from
Jul 2, 2020
Merged

[Feature] support old-hd-path flag #349

merged 1 commit into from
Jul 2, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jun 22, 2020 •
edited
Loading

Summary of changes

  • Receive --old-hd-path flag
  • Delay config seal time to viper pre-run step to apply --old-hd-path flag

close #356

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added the client rest / cli code improvements label Jun 22, 2020
@yun-yeo yun-yeo requested a review from hanjukim June 22, 2020 02:08
@yun-yeo yun-yeo self-assigned this Jun 22, 2020
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #349 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #349   +/-   ##
========================================
  Coverage    65.08%   65.08%           
========================================
  Files          101      101           
  Lines         5113     5113           
========================================
  Hits          3328     3328           
  Misses        1581     1581           
  Partials       204      204

@yun-yeo yun-yeo added the enhancement New feature or request label Jun 22, 2020
@dokwon
Copy link
Contributor

dokwon commented Jun 26, 2020

@YunSuk-Yeo is this WIP?

@dokwon
Copy link
Contributor

dokwon commented Jun 26, 2020

Would be great if we could include the motivation for this PR in the PR body, or a link to a relevant issue.

@dokwon dokwon self-requested a review June 26, 2020 07:36
dokwon
dokwon suggested changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to issue / add explanation for changes

@yun-yeo yun-yeo requested a review from dokwon June 29, 2020 07:24
@hanjukim hanjukim requested review from dokwon and removed request for dokwon June 30, 2020 10:35
@hanjukim hanjukim added this to the Columbus-4 RC1 milestone Jul 1, 2020
@dokwon dokwon merged commit 14c4e85 into develop Jul 2, 2020
@dokwon dokwon deleted the feature/old-hd-path branch July 2, 2020 05:47
tuky191 pushed a commit that referenced this pull request Nov 20, 2023
@fragwuerdig @nghuyenthevinh2000
fix: set min commission back to 5% (#349)
fef5b36 
Co-authored-by: nghuyenthevinh2000 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokwon dokwon dokwon approved these changes

@hanjukim hanjukim hanjukim approved these changes

Assignees

@yun-yeo yun-yeo

Labels
client rest / cli code improvements enhancement New feature or request
Projects
None yet
Milestone
Columbus-4 RC.1
Development

Successfully merging this pull request may close these issues.

[FEATURE] old hd path support
3 participants
@yun-yeo @dokwon @hanjukim