fix: stringify yes and no map keys #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
pushed a commit
that referenced
this pull request
Aug 4, 2020
yun-yeo
pushed a commit
that referenced
this pull request
Sep 22, 2020
* add columbus-4 genesis migration script * implement indicators querier for tax rate update * add public option at starting rest-server & enforce to use tx.height option when public option is on * fix(treasury): indicator endpoint feat(treasury): indicator swagger definition * fix: stringify yes and no map keys (#379) * change module account name & permission key * apply core module migration script * add pretty optiong * add new modules: msgauth, wasm, mint to script * update script for wasm params and expected time * remove wasm gas_multiplier params from genesis migration script * add changelog Co-authored-by: Paul Kim <[email protected]> Co-authored-by: Jesse Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
In swagger definition,
TallyResultresponse properties hasyesandnoas map keys. These are treated respectivelytrueandfalsein yaml spec (🤷♂️) . This makes spec compliant go yaml parser scream, as in golang maps cannot havebooltype as keys.Report of required housekeeping
(FOR ADMIN) Before merging