Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply review for v0.4.2 #447

Closed
wants to merge 1 commit into from
Closed

Apply review for v0.4.2 #447

wants to merge 1 commit into from

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Feb 16, 2021

Summary of changes

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from dokwon February 16, 2021 06:53
@yun-yeo yun-yeo self-assigned this Feb 16, 2021
@yun-yeo yun-yeo added the enhancement New feature or request label Feb 16, 2021
@dokwon
Copy link
Contributor

dokwon commented Feb 16, 2021

@YunSuk-Yeo you can just update the currently open PR instead of opening a new one

@dokwon dokwon closed this Feb 16, 2021
@yun-yeo yun-yeo deleted the review-fix branch February 16, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokwon dokwon Awaiting requested review from dokwon

Assignees

@yun-yeo yun-yeo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yun-yeo @dokwon