Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] fix proto urls #557

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[Bugfix] fix proto urls #557

merged 1 commit into from
Sep 15, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Sep 15, 2021

Summary of changes

Fix proto query urls to fit syntax

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Sep 15, 2021
@yun-yeo yun-yeo requested a review from hanjukim September 15, 2021 07:42
@yun-yeo yun-yeo added bug Something isn't working client rest / cli code improvements labels Sep 15, 2021
@yun-yeo yun-yeo merged commit 28aa765 into main Sep 15, 2021
@yun-yeo yun-yeo deleted the bugfix/update-proto-query-url branch September 15, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanjukim hanjukim hanjukim approved these changes

Assignees

@yun-yeo yun-yeo

Labels
bug Something isn't working client rest / cli code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yun-yeo @hanjukim