Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bump] SDK versions to [email protected] and [email protected] #594

Merged
merged 5 commits into from
Nov 16, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Oct 26, 2021

Summary of changes

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added the enhancement New feature or request label Oct 26, 2021
@yun-yeo yun-yeo requested a review from hanjukim October 26, 2021 01:44
@yun-yeo yun-yeo self-assigned this Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #594 (2d8ed82) into main (19b75bf) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   44.69%   44.72%   +0.02%     
==========================================
  Files         120      120              
  Lines        6967     6967              
==========================================
+ Hits         3114     3116       +2     
+ Misses       3614     3613       -1     
+ Partials      239      238       -1     
Impacted Files Coverage Δ
x/oracle/tally.go 91.89% <0.00%> (+5.40%) ⬆️

hanjukim
hanjukim previously approved these changes Nov 1, 2021
@yun-yeo
Copy link
Contributor Author

yun-yeo commented Nov 1, 2021

tendermint/tendermint#7106 make the lcd query to run in single thread :(

but the grpc query is still in multi thread (ref)

@yun-yeo yun-yeo merged commit ebf498f into main Nov 16, 2021
@yun-yeo yun-yeo deleted the bump/sdk branch November 16, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants