Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply cosmos-sdk proto updates #658

Merged
merged 2 commits into from
Feb 3, 2022
Merged

apply cosmos-sdk proto updates #658

merged 2 commits into from
Feb 3, 2022

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jan 11, 2022

Summary of changes

Apply cosmos proto changes

Critical Change is
from /cosmos/bank/v1beta1/balances/{address}/{denom}
to /cosmos/bank/v1beta1/balances/{address}/by_denom?denom={denom}

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added client rest / cli code improvements docs Documentation labels Jan 11, 2022
@yun-yeo yun-yeo requested review from hanjukim and Vritra4 January 11, 2022 08:29
@yun-yeo yun-yeo self-assigned this Jan 11, 2022
@yun-yeo yun-yeo changed the title update proto and swagger apply cosmos-sdk proto updates Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #658 (2a156b7) into main (0c293aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files         120      120           
  Lines        6999     6999           
=======================================
  Hits         3124     3124           
  Misses       3630     3630           
  Partials      245      245           

@yun-yeo yun-yeo merged commit ad4ed43 into main Feb 3, 2022
@yun-yeo yun-yeo deleted the proto-update branch February 3, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client rest / cli code improvements docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants