Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Bump AWS provider version to 5.82, added VPC Origin support #153

Merged

Conversation

destornillador
Copy link
Contributor

@destornillador destornillador commented Dec 21, 2024

Description

Added support for VPC origin.

New:

  • Resources:
    • aws_cloudfront_vpc_origin
  • Variables:
    • create_vpc_origin
    • vpc_origin
  • Outputs:
    • cloudfront_vpc_origin_ids

Update:

Motivation and Context

Closes #152

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

A stripped-down version of examples/complete was used where the VPC origin is created both by the module and by passing an external vpc_origin_id. In both cases, a private EC2 instance with NGINX installed was used as the origin and successfully accessed through the CloudFront distribution.

@destornillador destornillador changed the title Feat: Added VPC Origin support feat: Added VPC Origin support Dec 21, 2024
examples/complete/main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@antonbabenko antonbabenko changed the title feat: Added VPC Origin support feat!: Bump AWS provider version to 5.82, added VPC Origin support Dec 22, 2024
@antonbabenko antonbabenko merged commit 9ff6c63 into terraform-aws-modules:master Dec 22, 2024
7 checks passed
@antonbabenko
Copy link
Member

Thanks, @destornillador, for this contribution!

antonbabenko pushed a commit that referenced this pull request Dec 22, 2024
## [4.0.0](v3.4.1...v4.0.0) (2024-12-22)

### ⚠ BREAKING CHANGES

* Bump AWS provider version to 5.82, added VPC Origin support (#153)

### Features

* Bump AWS provider version to 5.82, added VPC Origin support ([#153](#153)) ([9ff6c63](9ff6c63))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for CloudFront VPC origins
2 participants