feat: Add support for cluster and container definition custom CloudWatch log group names

[ivan-sukhomlyn]

Description

The possibility to define a custom AWS CloudWatch LogGroup name instead of a pre-defined pattern at the module.

Motivation and Context

Previously, it was impossible to define the custom name of CW LogGroup while creating a group with the modules.

Breaking Changes

No.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

ECS Cluster Log Group

• config

module "ecs_cluster" {
  source = "../../../../../../open-source/terraform-aws-ecs/modules/cluster"
  #  source  = "terraform-aws-modules/ecs/aws//modules//cluster"
  #  version = "~> 5.7"
  # ...
  cloudwatch_log_group_name = "/aws/ecs/custom-cluster-test"

• terraform plan

  # module.ecs_cluster.aws_cloudwatch_log_group.this[0] must be replaced
-/+ resource "aws_cloudwatch_log_group" "this" {
      ~ arn               = "arn:aws:logs:xxx:xxx:log-group:/aws/ecs/xxx" -> (known after apply)
...
      ~ name              = "/aws/ecs/xxx" -> "/aws/ecs/custom-cluster-test" # forces replacement
...
    }

• config

module "ecs_cluster" {
  # ...
  # cloudwatch_log_group_name = "/aws/ecs/custom-cluster-test"

• terraform plan

No changes. Your infrastructure matches the configuration.

ECS Containers' Log Group

• config

module "ecs_container_def_custom" {
  source = "../../../../../../open-source/terraform-aws-ecs/modules/container-definition"
  #  source  = "terraform-aws-modules/ecs/aws//modules//container-definition"
  #  version = "~> 5.7"
  # ...
  enable_cloudwatch_logging   = true
  create_cloudwatch_log_group = true
  cloudwatch_log_group_name = "/aws/ecs/test-custom-name"

• terraform plan

Terraform will perform the following actions:

  # module.ecs_container_def_custom.aws_cloudwatch_log_group.this[0] will be created
  + resource "aws_cloudwatch_log_group" "this" {
      + arn               = (known after apply)
      + id                = (known after apply)
      + log_group_class   = (known after apply)
      + name              = "/aws/ecs/test-custom-name"
      ...
    }

• I have executed pre-commit run -a on my pull request

[bryantbiggs]

Why is this change necessary or warranted?

[ivan-sukhomlyn]

@bryantbiggs For example, there's a custom convention for AWS CW LogGroups at some projects, which is different from the current pattern /aws/ecs/${var.service}/${var.name}.

In that case, it will be nice to have the possibility to define a custom name for a log group instead of creating it outside of the module and passing it through vars.

Also, the same functionality is already present for IAM roles via separate vars like tasks_iam_role_name, as for example.

[bryantbiggs]

I can't say I agree with it - seems to add more complexity than its worth but we'll go with it

[antonbabenko]

This PR is included in version 5.9.0 🎉

[ivan-sukhomlyn]

@bryantbiggs thank you! 🙂
It will allow the creation of a CW LogGroup inside the module instead of managing it outside in case of the custom log group name requirement.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.