fix: Pass CloudWatch log group name from the service module to the container definition module #168
Conversation
bryantbiggs
changed the title
|
looks good - lets just update one example to both show this usage and verify its correct |
ivan-sukhomlyn
changed the title
|
@bryantbiggs thanks! The complete example has been updated with custom CW log group name usage. |
|
|
||
| enable_cloudwatch_logging = true | ||
| create_cloudwatch_log_group = true | ||
| cloudwatch_log_group_name = "/aws/ecs/${local.name}/${local.container_name}" |
There was a problem hiding this comment.
It's an example with available variables 🙂
Thanks for reviewing!
For example, I want to create a CW log group with the /aws/ecs/${local.name}/service/${local.container_name} pattern and it was not possible in current implementation.
It was a possibility to create it additionally and pass through the variable, but I saw the same functionality for IAM roles and decided to make this small improvement to manage all required resources for ECS service logging inside the module.
### [5.9.1](v5.9.0...v5.9.1) (2024-02-19) ### Bug Fixes * Pass CloudWatch log group name from the service module to the container definition module ([#168](#168)) ([9a7c9da](9a7c9da))
|
This PR is included in version 5.9.1 🎉 |
…ntainer definition module (terraform-aws-modules#168) * fix: Custom CW Log Group name definition from service module * example of custom CW log group name definition * move custom CW log group name to autoscaling example
### [5.9.1](terraform-aws-modules/terraform-aws-ecs@v5.9.0...v5.9.1) (2024-02-19) ### Bug Fixes * Pass CloudWatch log group name from the service module to the container definition module ([terraform-aws-modules#168](terraform-aws-modules#168)) ([9a7c9da](terraform-aws-modules@9a7c9da))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Fix the passing of the custom CloudWatch log group name through the
servicemodule to thecontainer-definitionone introduced in #160.Motivation and Context
To have the ability to pass custom CloudWatch log group name from the
servicemodule.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request