Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that custom KMS key is not created if encryption is not enabled, support computed values in cluster name #2318

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Dec 6, 2022

Description

  • Ensure that custom KMS key is not created if encryption is not enabled
  • Avoid throwing an index error when users provide their own custom launch template instead of the module creating a custom launch template
  • Support instances where a computed value is passed into the cluster name, such as using random provider resources

Motivation and Context

Breaking Changes

  • The default KMS key alias for the cluster name will be re-created but this is generally a safe process since its just an identifier. Otherwise, no breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

…ter name, such as using random provider resources
@bryantbiggs bryantbiggs changed the title fix: Ensure that custom KMS key is not created if encryption is not enabled fix: Ensure that custom KMS key is not created if encryption is not enabled, support computed values in cluster name Dec 6, 2022
@antonbabenko
Copy link
Member

This issue has been resolved in version 19.0.4 🎉

@bryantbiggs bryantbiggs deleted the fix/kms-key-creation branch December 7, 2022 17:03
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants