Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #424
I am not sure if this's a bug on upstream (terraform show), a bug on terraform-compliance, or a design shortcoming.
The reference in the plan is
module.ecr_repository
instead ofmodule.ecr_repository.ecr_name
. (Which can't be split into three and breaks)Let's say you had the following inside your module
how can terraform-compliance know if the code wants to reference
ecr_name
ornot_ecr_name
? It needs the third part of the reference.(Both
ecr_name
andnot_ecr_name
appear in the plan once, so we can't look for them somewhere else in the plan)How can the missing information be added to the reference?
Until we are able to answer that, this pr addresses the issue by mounting the resource to all resources within the target module and warns the user about it.
Other Ideas
Quick note
module.ecr_repository.ecr_name
would not be the correct reference either, sincefor_each
names the resources differently. I wanted to describe it that way as it's somewhat less confusing.