-
Notifications
You must be signed in to change notification settings - Fork 62
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #22 from khos2ow/housekeeping
Repositiory housekeeping items
- Loading branch information
Showing
8 changed files
with
180 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,33 @@ | ||
# Description | ||
<!-- | ||
Thank you for helping to improve terraform-docs! | ||
Please read through https://git.io/Jt3K5 if this is your first time opening a | ||
terraform-docs pull request. | ||
--> | ||
|
||
# Changes | ||
- | ||
### Description of your changes | ||
|
||
# TODO | ||
- [ ] TODO | ||
<!-- | ||
Briefly describe what this pull request does. Be sure to direct your reviewers' | ||
attention to anything that needs special consideration. | ||
We love pull requests that resolve an open terraform-docs issue. If yours does, you | ||
can uncomment the below line to indicate which issue your PR fixes, for example | ||
"Fixes #500": | ||
--> | ||
|
||
<!-- Fixes # --> | ||
|
||
I have: | ||
|
||
- [ ] Read and followed terraform-docs' [contribution process]. | ||
|
||
### How has this code been tested | ||
|
||
<!-- | ||
Before reviewers can be confident in the correctness of this pull request, it | ||
needs to tested and shown to be correct. Briefly describe the testing that has | ||
already been done or which is planned for this change. | ||
--> | ||
|
||
[contribution process]: https://git.io/Jt3K5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# Contributing to terraform-docs GitHub Action | ||
|
||
Welcome, and thank you for considering contributing to terraform-docs GitHub | ||
Action. We encourage you to help out by raising issues, improving documentation, | ||
fixing bugs, or adding new features | ||
|
||
## Contributing Codev | ||
|
||
To contribute bug fixes or features to terraform-docs GitHub Action: | ||
|
||
1. Communicate your intent. | ||
1. Make your changes. | ||
1. Test your changes. | ||
1. Update documentation and examples. | ||
1. Open a Pull Request (PR). | ||
|
||
Communicating your intent lets the terraform-docs maintainers know that you intend | ||
to contribute, and how. This sets you up for success - you can avoid duplicating | ||
an effort that may already be underway, adding a feature that may be rejected, | ||
or heading down a path that you would be steered away from at review time. The | ||
best way to communicate your intent is via a detailed GitHub issue. Take a look | ||
first to see if there's already an issue relating to the thing you'd like to | ||
contribute. If there isn't, please raise a new one! Let us know what you'd like | ||
to work on, and why. | ||
|
||
Be sure to practice [good git commit hygiene] as you make your changes. All but | ||
the smallest changes should be broken up into a few commits that tell a story. | ||
Use your git commits to provide context for the folks who will review PR, and | ||
the folks who will be spelunking the codebase in the months and years to come. | ||
Ensure each of your commits is signed-off in compliance with the [Developer | ||
Certificate of Origin] by using `git commit -s`. | ||
|
||
Once your change is written, tested, and documented the final step is to have it | ||
reviewed! You'll be presented with a template and a small checklist when you | ||
open a PR. Please read the template and fill out the checklist. Please make all | ||
PR request changes in subsequent commits. This allows your reviewers to see what | ||
has changed as you address their comments. Be mindful of your commit history as | ||
you do this - avoid commit messages like "Address review feedback" if possible. | ||
If doing so is difficult a good alternative is to rewrite your commit history to | ||
clean them up after your PR is approved but before it is merged. | ||
|
||
In summary, please: | ||
|
||
* Discuss your change in a GitHub issue before you start. | ||
* Use your Git commit messages to communicate your intent to your reviewers. | ||
* Sign-off on all Git commits by running `git commit -s` | ||
* Add or update tests for all changes. | ||
* Update all relevant documentation and examples. | ||
* Don't force push to address review feedback. Your commits should tell a story. | ||
* If necessary, tidy up your git commit history once your PR is approved. | ||
|
||
Thank you for reading through our contributing guide! We appreciate you taking | ||
the time to ensure your contributions are high quality and easy for our community | ||
to review and accept. | ||
|
||
[good git commit hygiene]: https://www.futurelearn.com/info/blog/telling-stories-with-your-git-history | ||
[Developer Certificate of Origin]: https://github.com/apps/dco |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
Developer Certificate of Origin | ||
Version 1.1 | ||
|
||
Copyright (C) 2004, 2006 The Linux Foundation and its contributors. | ||
660 York Street, Suite 102, | ||
San Francisco, CA 94110 USA | ||
|
||
Everyone is permitted to copy and distribute verbatim copies of this | ||
license document, but changing it is not allowed. | ||
|
||
|
||
Developer's Certificate of Origin 1.1 | ||
|
||
By making a contribution to this project, I certify that: | ||
|
||
(a) The contribution was created in whole or in part by me and I | ||
have the right to submit it under the open source license | ||
indicated in the file; or | ||
|
||
(b) The contribution is based upon previous work that, to the best | ||
of my knowledge, is covered under an appropriate open source | ||
license and I have the right under that license to submit that | ||
work with modifications, whether created in whole or in part | ||
by me, under the same open source license (unless I am | ||
permitted to submit under a different license), as indicated | ||
in the file; or | ||
|
||
(c) The contribution was provided directly to me by some other | ||
person who certified (a), (b) or (c) and I have not modified | ||
it. | ||
|
||
(d) I understand and agree that this project and the contribution | ||
are public and that a record of the contribution (including all | ||
personal information I submit with it, including my sign-off) is | ||
maintained indefinitely and may be redistributed consistent with | ||
this project or the open source license(s) involved. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters