Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update bastion image family to debian-11 #102

Merged

Conversation

catherinetcai
Copy link
Contributor

Fixes: #101

CentOS 8 is EOL. CentOS Stream 9 may be close enough?

@catherinetcai catherinetcai requested a review from a team as a code owner March 10, 2022 18:09
@google-cla
Copy link

google-cla bot commented Mar 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@comment-bot-dev
Copy link

comment-bot-dev commented Mar 10, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @catherinetcai
Based on #101 (comment) and https://cloud.google.com/compute/docs/eol/centos-eol-guidance I am leaning towards debian as the default. WDYT?

@bharathkkb bharathkkb changed the title Update bastion image family to be Centos-Stream-9 feat!: Update bastion image family to be Centos-Stream-9 Mar 11, 2022
@catherinetcai
Copy link
Contributor Author

@bharathkkb I'm good with that. I'll update.

@bharathkkb bharathkkb changed the title feat!: Update bastion image family to be Centos-Stream-9 feat!: Update bastion image family to debian-11 Mar 14, 2022
@bharathkkb bharathkkb merged commit 9f935eb into terraform-google-modules:master Mar 14, 2022
@catherinetcai catherinetcai deleted the fix-centos-image branch March 14, 2022 23:43
@kevincantu
Copy link

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default for image_family seems to be outdated
4 participants