Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_api_gateway_api_key - add attributes #10821

Merged
merged 7 commits into from
Jan 18, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 9, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

- data/data_source_api_gateway_api_key: Add `tags`, `description`, `enabled`, `created_date`,   `last_updated_date` attributes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsApiGatewayApiKey'
=== RUN   TestAccDataSourceAwsApiGatewayApiKey
=== PAUSE TestAccDataSourceAwsApiGatewayApiKey
=== CONT  TestAccDataSourceAwsApiGatewayApiKey
--- PASS: TestAccDataSourceAwsApiGatewayApiKey (34.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	54.777s

...

@DrFaust92 DrFaust92 requested a review from a team November 9, 2019 14:49
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 9, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2020
@bflad bflad added this to the v2.46.0 milestone Jan 18, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsApiGatewayApiKey (8.38s)

@bflad bflad merged commit 4244937 into hashicorp:master Jan 18, 2020
bflad added a commit that referenced this pull request Jan 18, 2020
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the d/apigw_ap_key-attribuites branch January 24, 2020 16:28
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants