-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/kubernetes_cluster: support for outbound_type
within the network_profile
block
#6120
r/kubernetes_cluster: support for outbound_type
within the network_profile
block
#6120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @baboune, thanks for the PR. Overall this looks great but I've left a couple comments inline - basically we don't ignore case without good reason.
azurerm/internal/services/containers/resource_arm_kubernetes_cluster.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/monitor/resource_arm_monitor_metric_alert.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/monitor/resource_arm_monitor_metric_alert.go
Outdated
Show resolved
Hide resolved
@katbyte I did the updates. Waiting on your for the webhook vs WebHook part. |
Hi @katbyte Can this move forward or what else is required? |
Really waiting for this one! Thank you everyone |
What else could I do to move this forward? |
431ac01
to
84c24a0
Compare
@tombuildsstuff I appreciate you taking time to include this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @baboune
Thanks for this PR :)
I've taken a look through and left some comments inline, but this is off to a good start. Given that there's a number of AKS PR's open (which until recently have been blocked by breaking changes to the AKS API) - I'm currently working through the open AKS PR's to resolve any merge conflicts and get them merged.
As such I hope you don't mind but whilst I've left comments inline regarding which changes are needed - I'm going to push a commit to resolve this so that we can get this merged and ship this in the v2.5 release of the Azure Provider.
Thanks!
azurerm/internal/services/containers/resource_arm_kubernetes_cluster.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/resource_arm_kubernetes_cluster.go
Outdated
Show resolved
Hide resolved
dismissing since changes have been pushed
outbound_type
within the network_profile
block
Acceptance tests look good 👍 |
This has been released in version 2.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.5.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
I downsized all the changes from #5757 to the bare minimal go changes to add the AKS outboundType feature #5583.
Did not look at all the dependency changes.
Did not introduce azure-sdk-for-go v0.40.
Fixes #5583 .
Closes #5757