add base url variable expected to be exported in the github provider #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcudit
approved these changes
Apr 30, 2020
|
From memory, next steps to release this are to cut a new release and update the action version on the provider GitHub side. |
|
thanks for the review @jcudit ! i'm going to merge here then and then just to confirm we'll make the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to support passing
GITHUB_BASE_URLin theterraform-provider-githubworkflowused in tests (e.g. currently missing and failing in https://github.com/terraform-providers/terraform-provider-github/pull/424/checks)