Measurement tools panel #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just restarted Travis. Looking into this now. |
| @@ -0,0 +1,145 @@ | |||
| Ext.define('MoMo.client.view.button.ShowMeasureToolsPanelController', { | |||
There was a problem hiding this comment.
License and API docs missing.
|
Hi @annarieger, I have added a couple of comments which you may want to take. This is good to go once the mentioned points are addressed and the build is green. Thanks! |
|
Thanks for the review, @marcjansen. I've addressed your notes and created an issue for the translation harmonization. Merge it after travis is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a measurement tools functionality. Via
momo-button-showmeasuretoolspanelbutton a panel containing two tools to measure distances and areas can be shown. The logic of the single tools is inherited fromBasiGX.view.button.MeasureclassCorresponding PR in backend: terrestris/momo3-backend#29
Please review @buehner @marcjansen