fix: types from dependency updates

terrestris · Mar 14, 2022 · 8c79103 · 8c79103
1 parent d18624e
commit 8c79103
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/Button/DigitizeButton/DigitizeButton.tsx b/src/Button/DigitizeButton/DigitizeButton.tsx
@@ -526,9 +526,9 @@ class DigitizeButton extends React.Component<DigitizeButtonProps, DigitizeButton
       map
     } = this.props;
 
-    let digitizeLayer = digitizeLayerName ? MapUtil.getLayerByName(map, digitizeLayerName) : null;
+    let digitizeLayer = digitizeLayerName ? MapUtil.getLayerByName(map, digitizeLayerName) as OlLayerVector<OlSourceVector<OlGeometry>>: null;
 
-    if (!digitizeLayer) {
+    if (digitizeLayer == null) {
       digitizeLayer = new OlLayerVector({
         source: new OlSourceVector({
           features: new OlCollection()
@@ -544,7 +544,7 @@ class DigitizeButton extends React.Component<DigitizeButtonProps, DigitizeButton
 
     this._digitizeLayer = digitizeLayer;
 
-    this._digitizeFeatures = digitizeLayer.getSource().getFeaturesCollection();
+    this._digitizeFeatures = digitizeLayer.getSource()?.getFeaturesCollection() ?? null;
   };
 
   /**

diff --git a/src/Button/MeasureButton/MeasureButton.tsx b/src/Button/MeasureButton/MeasureButton.tsx
@@ -335,7 +335,7 @@ class MeasureButton extends React.Component<MeasureButtonProps> {
       map
     } = this.props;
 
-    let measureLayer = MapUtil.getLayerByName(map, measureLayerName);
+    let measureLayer = MapUtil.getLayerByName(map, measureLayerName) as OlLayerVector<OlSourceVector<OlGeometry>>;
 
     if (!measureLayer) {
       measureLayer = new OlLayerVector({

diff --git a/src/Legend/Legend.tsx b/src/Legend/Legend.tsx
@@ -4,9 +4,9 @@ import _isEqual from 'lodash/isEqual';
 
 import Logger from '@terrestris/base-util/dist/Logger';
 import MapUtil from '@terrestris/ol-util/dist/MapUtil/MapUtil';
-import OlBaseLayer from 'ol/layer/Base';
 
 import { CSS_PREFIX } from '../constants';
+import { WmsLayer } from '../Util/typeUtils';
 
 export interface BaseProps {
   /**
@@ -16,7 +16,7 @@ export interface BaseProps {
   /**
    * The layer you want to display the legend of.
    */
-  layer: OlBaseLayer;
+  layer: WmsLayer;
   /**
    * An object containing additional request params like "{HEIGHT: 400}" will
    * be transformed to "&HEIGHT=400" an added to the GetLegendGraphic request.
@@ -105,7 +105,7 @@ export class Legend extends React.Component<LegendProps, LegendState> {
    * @param layer The layer to get the legend graphic request for.
    * @param extraParams The extra params.
    */
-  getLegendUrl(layer: OlBaseLayer, extraParams: any) {
+  getLegendUrl(layer: WmsLayer, extraParams: any) {
     let legendUrl;
 
     if (layer.get('legendUrl')) {

diff --git a/src/Util/DigitizeUtil.ts b/src/Util/DigitizeUtil.ts
@@ -95,7 +95,7 @@ export class DigitizeUtil {
    * @param map
    */
   static getDigitizeLayer(map: OlMap): OlVectorLayer<OlSourceVector<Geometry>> {
-    let digitizeLayer = MapUtil.getLayerByName(map, DigitizeUtil.DIGITIZE_LAYER_NAME);
+    let digitizeLayer = MapUtil.getLayerByName(map, DigitizeUtil.DIGITIZE_LAYER_NAME) as OlVectorLayer<OlSourceVector>;
 
     if (!digitizeLayer) {
       digitizeLayer = new OlLayerVector({

diff --git a/src/Util/typeUtils.ts b/src/Util/typeUtils.ts
@@ -5,7 +5,7 @@ import OlTileWMS from 'ol/source/TileWMS';
 import OlImageLayer from 'ol/layer/Image';
 import OlTileLayer from 'ol/layer/Tile';
 
-export type WmsLayer = OlImageLayer<OlImageWMS> | OlTileLayer<OlTileWMS>;
+export type WmsLayer = OlImageLayer<OlImageWMS> | OlTileLayer<OlTileWMS> | OlLayer<OlImageWMS | OlTileWMS>;
 
 export function isWmsLayer(layer: OlBaseLayer): layer is OlLayer<OlImageWMS | OlTileWMS, any> {
   if (layer instanceof OlLayer) {