Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CoordinateInfo fetch options #3654

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mholthausen
Copy link
Member

Description

Optimize fetch options in CoordinateInfo to handle either an object with request options per layer UID or a function returning options based on WmsLayer.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@terrestris/devs please review

Optimize fetch options in CoordinateInfo to handle either an object
with request options per layer UID or a function returning options
based on WmsLayer. Improves feature fetching via GetFeatureInfo.
@mholthausen mholthausen merged commit ff84db7 into main Nov 29, 2023
1 check passed
@dnlkoch
Copy link
Member

dnlkoch commented Nov 29, 2023

🎉 This PR is included in version 23.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants