Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag and drop in LayerTree #4155

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix drag and drop in LayerTree #4155

merged 2 commits into from
Dec 11, 2024

Conversation

LukasLohoff
Copy link
Member

@LukasLohoff LukasLohoff commented Dec 11, 2024

Description

This removes onDragStart from the layer tree title node.

Please note that if you want to use a draggable component inside the layer tree title node via nodeTitleRenderer, you will have to stop drag events on that node yourself. This can be done by applying the properties to the child node.

Example change:

terrestris/shogun-gis-client#1777

@terrestris/devs Please review

Related issues or pull requests

Source PR: #3894

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm run check locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@FritzHoing
Copy link
Contributor

Can we add a information in the documentary that a onDragStart is needed when implemented to prevent the dragging of the div?

@LukasLohoff
Copy link
Member Author

Can we add a information in the documentary that a onDragStart is needed when implemented to prevent the dragging of the div?

Good idea, added in 4fdca98

@LukasLohoff LukasLohoff merged commit e3b3f8e into main Dec 11, 2024
1 check passed
@dnlkoch
Copy link
Member

dnlkoch commented Dec 11, 2024

🎉 This PR is included in version 26.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants