Handlermapping qualifier #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlkoch
requested changes
Aug 21, 2017
| <!-- Use the full path within the current servlet context to find an appropriate handler. | ||
| s. http://docs.spring.io/spring/docs/4.0.7.RELEASE/spring-framework-reference/htmlsingle/#mvc-handlermapping --> | ||
| <beans:bean id="handlerMapping" class="org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping"> | ||
| <beans:property name="alwaysUseFullPath" value="true"/> |
There was a problem hiding this comment.
Is this needed for the current archetype context?
There was a problem hiding this comment.
This could be useful for the more complex projects using multiple controllers in its context, but you're right, for the archetype that would be enough to use default config (alwaysUseFullPath=false).
| @@ -26,6 +26,7 @@ | |||
| * method-level @RequestMapping annotations in @Controller classes. | |||
| */ | |||
| @Autowired | |||
| @Qualifier("handlerMapping") | |||
There was a problem hiding this comment.
Please rename the qualifier to something more meaningful, e.g. requestHandlerMapping.
dnlkoch
approved these changes
Aug 21, 2017
|
Thanks! Please merge! |
|
Thanks back, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently introduced controller
EndpointDocControllerfor endpoint to retrieve all request mappings as JSON (#265) contains no unique@Qualifierannotation forrequestMappingHandlerMappingwhat can be conceivably fragile.This MR introduces
handlerMappingbean inside of archetype servlet XML file and adds the corresponding qualifier to the controller mentioned above.Please review @chrismayer @terrestris/devs