-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce whitelist proxy microservice #410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlkoch
approved these changes
Oct 19, 2021
shogun-proxy/src/main/java/de/terrestris/shogun/config/HttpProxyWebSecurityConfig.java
Outdated
Show resolved
Hide resolved
Is the OpenAPI UI included in the MS? |
Not yet. Since no entities / REST / graphql endpoints end have been added here, I didn't see the need for this. However, I'll add this if wanted. |
No, I don't see any benefit neither - was just wondering. |
LukasLohoff
approved these changes
Oct 20, 2021
thx for reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a HTTP whitelist proxy microservice which is basically the migration of the existing one of
shogun-core
.The white-listed hosts can be added in the list
proxy.whitelist
inapplication.yml
.Plz review @terrestris/devs
Related issues or pull requests
Pull request type
Do you introduce a breaking change?
Checklist
Apache Licence Version 2.0.
mvn test
locally).