Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce whitelist proxy microservice #410

Merged
merged 7 commits into from
Oct 20, 2021
Merged

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Oct 18, 2021

Description

This PR introduces a HTTP whitelist proxy microservice which is basically the migration of the existing one of shogun-core.
The white-listed hosts can be added in the list proxy.whitelist in application.yml.

Plz review @terrestris/devs

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@ahennr ahennr changed the title Draft: Introduce whitelist proxy microservice Introduce whitelist proxy microservice Oct 19, 2021
@ahennr ahennr marked this pull request as draft October 19, 2021 11:29
@ahennr ahennr marked this pull request as ready for review October 19, 2021 11:32
shogun-proxy/pom.xml Outdated Show resolved Hide resolved
shogun-proxy/pom.xml Show resolved Hide resolved
@dnlkoch
Copy link
Member

dnlkoch commented Oct 19, 2021

Is the OpenAPI UI included in the MS?

@ahennr
Copy link
Member Author

ahennr commented Oct 19, 2021

Is the OpenAPI UI included in the MS?

Not yet. Since no entities / REST / graphql endpoints end have been added here, I didn't see the need for this. However, I'll add this if wanted.

@dnlkoch
Copy link
Member

dnlkoch commented Oct 19, 2021

No, I don't see any benefit neither - was just wondering.

@ahennr
Copy link
Member Author

ahennr commented Oct 20, 2021

thx for reviews

@ahennr ahennr merged commit 739b9ef into terrestris:main Oct 20, 2021
@ahennr ahennr deleted the shogun-proxy branch October 20, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants