Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure interceptor cache #422

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

LukasLohoff
Copy link
Member

@LukasLohoff LukasLohoff commented Oct 29, 2021

Description

  • enables caching of interceptorrules by adding @Cache annotation
  • configures repository queries to use specific query cache

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@terrestris/devs Please review

@LukasLohoff LukasLohoff changed the title feat: configure interceptor cache configure interceptor cache Oct 29, 2021
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I'm +1, thanks @LukasLohoff!

Just a question: Do we need to apply a custom ehcache.xml for the given cache regions?

@LukasLohoff
Copy link
Member Author

LukasLohoff commented Oct 29, 2021

Generally I'm +1, thanks @LukasLohoff!

Just a question: Do we need to apply a custom ehcache.xml for the given cache regions?

Ah yes we probably need a default ehcache.xml file for the interceptor, right?

Or is it enough to add interceptorrule_query and interceptorrules to the existing ehcache.xml?

@LukasLohoff
Copy link
Member Author

@dnlkoch Added a custom ehcache.xml in 86fae48. This ensures only interceptorrules and interceptor queries are cached.

Copy link
Member

@simonseyock simonseyock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@LukasLohoff LukasLohoff merged commit fc94a76 into terrestris:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants