Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set envers suffix instead of prefix #428

Merged
merged 2 commits into from
Nov 26, 2021
Merged

fix: set envers suffix instead of prefix #428

merged 2 commits into from
Nov 26, 2021

Conversation

simonseyock
Copy link
Member

Description

_rev is supposed to be a suffix not a prefix. With this change the value of @AuditTable and probably also the name of @AuditJoinTable can be omitted.

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Member

@LukasLohoff LukasLohoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Regarding the startup script: I think your fork doesn't know terrestris/shogun-docker@4fdcbc5 yet. Maybe a rebase will help?

@dnlkoch
Copy link
Member

dnlkoch commented Nov 19, 2021

The failing startup action should be fixed by #431.

@dnlkoch
Copy link
Member

dnlkoch commented Nov 19, 2021

@dependabot rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants