Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work-in-progress allows datasets to be defined in external packages through the entry point
pyterrier.dataset_provider
.The existing datasets have been moved into two providers:
builtin
(for default set of datasets), andirds
(for the ones provided by ir-datasets).This sets the stage for a few things:
pyterrier.datasets.DATASET_MAP
).A side benefit is that dataset objects don't need to be created until needed. This could reduce the import time of the core pyterrier package.
The diff looks messy due to moving stuff around. The key new bits are in
pyterrier/datasets/_core.py
.