add linters #361
Merged
add linters #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/tesla-http-proxy/main.go
Outdated
| fmt.Fprintln(out, nonLocalhostWarning) | ||
| fmt.Fprintln(out, "") | ||
| fmt.Fprintln(out, "Options:") | ||
| _, _ = fmt.Fprintf(out, "Usage: %s [OPTION...]\n", os.Args[0]) |
There was a problem hiding this comment.
Is there any way to disable error checking on printf?
// It is conventional not to worry about any
// error returned by Printf.
There was a problem hiding this comment.
quick search didn't yield any result for me on how to do this
There was a problem hiding this comment.
https://github.com/teslamotors/vehicle-command/pull/361/files#r1927807911
I'd also exclude file.Close.
Makefile
Outdated
| all: build | ||
|
|
||
| linters: install |
There was a problem hiding this comment.
Why is install a prerequisite?
| issues: | ||
| exclude-dirs: | ||
| - temp | ||
|
|
There was a problem hiding this comment.
issues:
exclude-dirs:
- temp
exclude:
- "Error return value of `fmt.Fprintln` is not checked"
agbpatro
force-pushed
the
add_linters
branch
3 times, most recently
from
d638a3a to
1bfa9ed
Compare
agbpatro
force-pushed
the
add_linters
branch
7 times, most recently
from
3e1eafb to
2387952
Compare
sethterashima
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a basic linter
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: