Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FromVCSECMessage.nominalError documentation #362

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix FromVCSECMessage.nominalError documentation #362

merged 1 commit into from
Jan 24, 2025

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Jan 24, 2025

Description

The referenced field is incorrect according to the proto
https://github.com/teslamotors/vehicle-command/blob/main/pkg/protocol/protobuf/vcsec.proto#L288

Fixes # (issue)

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

@sethterashima sethterashima merged commit 3f5835b into teslamotors:main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethterashima sethterashima sethterashima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bre77 @sethterashima