adds wifi events from js #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return 1; | ||
| } | ||
|
|
||
| size_t ssidlen = (size_t)lua_tonumber(L, ARG1); |
There was a problem hiding this comment.
Why do you pass the length from lua? You can get the length from colony_toconstdata.
| @@ -56,8 +56,8 @@ void hw_net_config(int should_connect_to_open_ap, int should_use_fast_connect, i | |||
| void hw_net_smartconfig_initialize(void); | |||
| void hw_net_disable (void); | |||
| // extern uint8_t tm_net_firmware_version (); | |||
| int hw_net_connect(const char *security_type, const char *ssid, const char *keys); | |||
| void hw_net_disconnect (void); | |||
| int hw_net_connect(const char *security_type, const char *ssid, const char *keys, size_t ssidlen, size_t keyslen); | |||
There was a problem hiding this comment.
ssid_len and it should follow ssid property. same with keys_len
|
Code review completed. Please shout at me to re-review. |
| @@ -56,8 +56,8 @@ void hw_net_config(int should_connect_to_open_ap, int should_use_fast_connect, i | |||
| void hw_net_smartconfig_initialize(void); | |||
| void hw_net_disable (void); | |||
| // extern uint8_t tm_net_firmware_version (); | |||
| int hw_net_connect(const char *security_type, const char *ssid, const char *keys); | |||
| void hw_net_disconnect (void); | |||
| int hw_net_connect(const char *security_type, const char *ssid, size_t ssidlen, const char *keys, size_t keyslen); | |||
underscores for all removing extra space
|
r+ and go |
This was referenced Jul 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with tessel/t1-runtime#264