Updating to depend on TK 1.4 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config[:instance_type] = config[:flavor_id] || 'm1.small' | ||
| end | ||
| if config[:ssh_timeout] | ||
| # TODO NOOOOOOOOOO |
There was a problem hiding this comment.
@fnichol I really, really hate doing this. What would you suggest?
…ge config we don't overwrite the AMI default
| gem.add_dependency 'fog' | ||
| gem.add_dependency "test-kitchen", "= 1.4.0.rc.1" | ||
| gem.add_dependency 'excon' | ||
| gem.add_dependency 'multi_json' |
There was a problem hiding this comment.
Is there a reason for multi_json other than older Ruby support? Test Kitchen only works on Ruby 1.9 and up which ships with a 'json' in stdlib. I may be missing a hidden dep in here though…
There was a problem hiding this comment.
When getting rid of Fog, I literally copied the transitive dependencies it was using (for the fetch_credentials call). I should probably update that to just use json.
|
@tyler-ball Looking really good! |
This was referenced Apr 23, 2015
Closed
|
Sweet, 👍 |
tyler-ball
added a commit
that referenced
this pull request
Apr 23, 2015
Updating to depend on TK 1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking advantage of the new base class and transport logic. Also replacing the Fog dependency with the aws-sdk dependency.
\cc @fnichol