Support selection of private ip #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep. Will take a look next week when I'm back in the office. |
|
@LordCope pingles 😄 |
|
Refactored and added tests. |
| @@ -19,7 +19,7 @@ | |||
| require 'benchmark' | |||
| require 'json' | |||
| require 'fog' | |||
|
|
|||
| require 'pry' | |||
There was a problem hiding this comment.
Sorry - this can probably come out...
|
After pairing on this, we're ready to merge |
fnichol
added a commit
that referenced
this pull request
Jan 27, 2014
Support selection of private ip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When operating in a VPC environment, in which the security group does not allow access via SSH to the external IP address of an instance, it is necessary to be able to enforce the use of the private IP address.
This patch makes a config setting available to the EC2 driver which defaults to 'public' but which may be set to 'private'.