Dynamically find default images for many platforms #221

jkeiser · 2016-02-10T05:00:18Z

Use search to find latest official AMI of the given OS and version on your region:
- ubuntu[-14[.04]]
- windows[-2008|-2012|-2012r2[sp1|sp2|rtm]]
- rhel[-major[.minor]]
- debian[-major]
- centos[-major[.minor]]
- freebsd[-major[.minor]]
- fedora[-major]
Prefer images by (in order of priority):
1. Latest version
2. SSD support over non-SSD
3. HVM (modern standard) over paravirtual
4. 64-bit over 32-bit
5. More recent image creation date
Default username: Auto-detect ssh username from image name
Default instance_type: t2.micro or t1.micro depending on image type (t2.micro for hvm, t1.micro for paravirtual)
Do not default availability zone (default of "a" doesn't work in all regions, and it's not necessary to pass AZ to create an instance)

- Use search to find latest official AMI of the given OS and version on your region: - ubuntu[-14[.04]] - windows[-2008|-2012|-2012r2[sp1|sp2|rtm]] - el[-<major>[.<minor>]] - debian[-<major>] - centos[-<major>[.<minor>]] - freebsd[-<major>[.<minor>]] - fedora[-<major>] - Prefer images by (in order of priority): 1. Latest version 2. SSD support over non-SSD 3. HVM (modern standard) over paravirtual 4. 64-bit over 32-bit 5. More recent image creation date - Restrict to paravirtual if a paravirtual-only instance type is chosen - Default username: Auto-detect ssh username from image name - Default instance_type: t2.micro or t1.micro depending on image type (t2.micro for hvm, t1.micro for paravirtual) - Do not pass availability zone unless specified (default of "a" doesn't work in all regions)

adamleff · 2016-02-10T22:25:27Z

README.md

+
+To get started, you need to install the software and set up your credentials and SSH key. Some of these steps you have probably already done, but we include them here for completeness.
+
+1. Install the latest ChefDK and put it in your path.


The TK maintainers are trying to ensure the project is agnostic to the use case. So, we should probably change this line to add "or ensure the test-kitchen gem is installed on your workstation"?

adamleff · 2016-02-10T22:34:09Z

lib/kitchen/driver/aws/standard_platform.rb

+            { name: key.to_s, values: Array(value).map { |v| v.to_s } }
+          end
+
+          # We prefer most recent first


This block from 83-110 is so cool. Neat implementation.

adamleff · 2016-02-10T22:47:15Z

lib/kitchen/driver/ec2.rb

@@ -57,20 +66,20 @@ class Ec2 < Kitchen::Driver::Base # rubocop:disable Metrics/ClassLength
      default_config :price,              nil
      default_config :retryable_tries,    60
      default_config :retryable_sleep,    5
-      default_config :aws_access_key_id,  nil
+      default_config :aws_access_key_id,  ENV["AWS_SSH_KEY_ID"]


I think I'm misunderstanding this change (and the one below in 72). The SSH key ID is not the same as the access_key. Can you help me understand this one?

It's wrong :)

adamleff · 2016-02-11T22:20:49Z

LGTM. @jkeiser this is some sooper-sweet stuff. Thanks for doing it.

Paging @test-kitchen/kitchen-ec2-maintainers

thommay · 2016-02-12T18:20:52Z

README.md

+  - name: ubuntu-i386
+  # 32-bit version of Debian 6
+  - name: debian-6-i386
+  # Latest 64-bit stable minor release of freebsd 10


do you mean 64bit? cos the name says i386

thommay · 2016-02-12T18:28:31Z

One teensy nit otherwise 👍

lamont-granquist · 2016-02-12T19:45:12Z

Would changing the priority of "64-bit vs 32-bit" to second change anything? HVM is also most likely more important than SSDs, but I suspect most of the SSD images are HVM 64-bit anyway.

And have you tried to converge chef-client on a t1.micro recently with a non-trivial runlist? The last time I tried running chef-client on a t1.micro it got a few minutes into a first converge and then it triggered the CPU governor which took away 99% of the CPU and it took the first converge a few more hours to run when it only had 1% of a CPU left. On a null run-list they probably finish fast enough that the governor does not kick on. That was several years ago so things might have changed, but they were not fit for purpose last time I checked.

jkeiser · 2016-02-13T02:59:28Z

@lamont-granquist hmm, I think doing amd64 > i386 earlier makes a lot of sense from a consistency point of view.

For the priority of HVM over SSD, do you think the SSD generally matters more, or the instance_type? That's the main thing you are selecting--the ability to actually run on most instance types.

As far as t1.micro, what do you suggest is a good default? I was super reluctant to bring it out of the free tier, but paravirtual images literally do not work on t1.micro.

lamont-granquist · 2016-02-13T03:05:33Z

What happens if you remove paravirt/t1.micro images completely? How much coverage do you lose?

jkeiser · 2016-02-13T03:15:45Z

You lose some OS's and versions (can't recall which). Certainly nothing recent. But I can't see a reason to just not support them at all, if we have a way ...

lamont-granquist · 2016-02-13T03:47:25Z

Yeah, but last time I tried the t1.micros they were pretty much unfit for purpose. That's kinda the point I'm not sure you're 'supporting' them just by adding the config...

jkeiser added 3 commits February 9, 2016 20:51

Don't require availability_zone to be specified

0a39697

Rename platform -> standard_platform

a8969e0

tyler-ball added the Developing label Feb 10, 2016

jkeiser added 3 commits February 9, 2016 21:14

Correctly detect debian version from codename

cae87b5

Correctly detect rhel version from image name

c2b3954

Correctly allow "windows" to find 2012r2

eea95be

jkeiser added New Feature and removed Developing labels Feb 10, 2016

Add comments and README quickstart

ac04ed9

jkeiser force-pushed the jk/ec2-defaults branch from b1e3f9a to ac04ed9 Compare February 10, 2016 20:30

adamleff reviewed Feb 10, 2016
View reviewed changes

Work with rubocop rules

cfc7c41

adamleff reviewed Feb 10, 2016
View reviewed changes

Readme clarification

a5804f1

adamleff reviewed Feb 10, 2016
View reviewed changes

jkeiser force-pushed the jk/ec2-defaults branch from c155f27 to c4b9f4c Compare February 11, 2016 22:07

jkeiser force-pushed the jk/ec2-defaults branch from c4b9f4c to 05ac620 Compare February 11, 2016 23:43

Don't assume ubuntu if there is no platform name

113195b

jkeiser force-pushed the jk/ec2-defaults branch from 05ac620 to 113195b Compare February 12, 2016 00:07

thommay reviewed Feb 12, 2016
View reviewed changes

Readme typo

481bc4e

jkeiser merged commit 481bc4e into master Feb 12, 2016

jkeiser mentioned this pull request Feb 12, 2016

add centos-6.5 amis #70

Closed

tas50 deleted the jk/ec2-defaults branch January 30, 2022 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamically find default images for many platforms #221

Dynamically find default images for many platforms #221

jkeiser commented Feb 10, 2016

adamleff Feb 10, 2016

jkeiser Feb 10, 2016

adamleff Feb 10, 2016

adamleff Feb 10, 2016

jkeiser Feb 11, 2016

adamleff commented Feb 11, 2016

thommay Feb 12, 2016

thommay commented Feb 12, 2016

lamont-granquist commented Feb 12, 2016

jkeiser commented Feb 13, 2016

lamont-granquist commented Feb 13, 2016

jkeiser commented Feb 13, 2016

lamont-granquist commented Feb 13, 2016


		To get started, you need to install the software and set up your credentials and SSH key. Some of these steps you have probably already done, but we include them here for completeness.

		1. Install the latest ChefDK and put it in your path.

Dynamically find default images for many platforms #221

Dynamically find default images for many platforms #221

Conversation

jkeiser commented Feb 10, 2016

adamleff Feb 10, 2016

Choose a reason for hiding this comment

jkeiser Feb 10, 2016

Choose a reason for hiding this comment

adamleff Feb 10, 2016

Choose a reason for hiding this comment

adamleff Feb 10, 2016

Choose a reason for hiding this comment

jkeiser Feb 11, 2016

Choose a reason for hiding this comment

adamleff commented Feb 11, 2016

thommay Feb 12, 2016

Choose a reason for hiding this comment

thommay commented Feb 12, 2016

lamont-granquist commented Feb 12, 2016

jkeiser commented Feb 13, 2016

lamont-granquist commented Feb 13, 2016

jkeiser commented Feb 13, 2016

lamont-granquist commented Feb 13, 2016