Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three new files translation #6

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

xfyuan
Copy link
Collaborator

@xfyuan xfyuan commented Dec 20, 2023

Including these docs:

  • docs/playbook.md
  • docs/profilers/memory_prof.md
  • docs/profilers/ruby_profilers.md

- docs/playbook.md
- docs/profilers/memory_prof.md
- docs/profilers/ruby_profilers.md
@xfyuan xfyuan added the docs Improvements or additions to documentation label Dec 20, 2023
@xfyuan xfyuan requested a review from palkan December 20, 2023 01:38
@xfyuan xfyuan self-assigned this Dec 20, 2023
@xfyuan
Copy link
Collaborator Author

xfyuan commented Dec 20, 2023

@palkan I've commit the 3 new files translation in a single PR. Don't want to make you waiting too long.)

About the old zh_cn version vs the latest en versions comparison and sync translations, I want to place it in a separate PR later. 🤝

@xfyuan
Copy link
Collaborator Author

xfyuan commented Dec 20, 2023

@palkan It seems there's some problem in the rubocop & forspell lint check. Could you please see take a look?

@palkan
Copy link
Contributor

palkan commented Dec 22, 2023

Thanks!

It seems there's some problem in the rubocop & forspell lint check. Could you please see take a look?

I will fix the forspell issue, but the RuboCop's one seem tricky; let's ignore it for now (we expect a major Rubocop-MD upgrade soon)

@palkan palkan merged commit 64b3fe8 into master Dec 22, 2023
2 of 4 checks passed
@palkan palkan deleted the add-translation-at-2023-12-12 branch December 22, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants