[test sdk automation new 3] test delete for compute RP #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update widgets.json
Update widgets.json
…sting Update widgets.json
…st-1 Update widgets.json
Testing assistant
…sistant Testing with spec change
* Rename bug.md to bug_report.md * Create config.yml
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 1
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 2
[Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1
[Internal testing] testing openapi-alps PR 511346 - Test 1
…t loadtesting java generation (#3158) * Update specificationRepositoryConfiguration.json * Update specificationRepositoryConfiguration.json * Update specificationRepositoryConfiguration.json * Update specificationRepositoryConfiguration.json
added powershell and arm schema
Next Steps to mergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| availabilitySet.json | 2023-09-01(f5b0b88) | 2023-09-01(main) |
| capacityReservation.json | 2023-09-01(f5b0b88) | 2023-09-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2023-09-01 | package-2023-09-01(f5b0b88) | package-2023-09-01(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'availabilitySetName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L37 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L38 |
|
The resource name parameter 'availabilitySetName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L353 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L385 |
|
The schema 'AvailabilitySetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L411 |
|
The schema 'AvailabilitySet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L458 |
|
The schema 'AvailabilitySetUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L476 |
|
The schema 'AvailabilitySetListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L494 |
|
The resource name parameter 'capacityReservationGroupName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L37 |
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L218 |
|
The resource name parameter 'capacityReservationGroupName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L390 |
|
The resource name parameter 'capacityReservationName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L390 |
|
A 202 response should include an Location response header. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L513 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L533 |
|
A 202 response should include an Location response header. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L572 |
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L601 |
|
The resource name parameter 'capacityReservationGroupName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L665 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'CapacityReservations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L670 |
| The response of operation:'AvailabilitySets_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L38 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L44 |
|
| The response of operation:'AvailabilitySets_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L95 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L101 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L161 |
|
| The response of operation:'AvailabilitySets_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L206 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L212 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L311 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: ComputeRP/stable/2023-09-01/availabilitySet.json#L360 |
|
| The response of operation:'CapacityReservationGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L38 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L44 |
|
| The response of operation:'CapacityReservationGroups_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: ComputeRP/stable/2023-09-01/capacityReservation.json#L101 |
️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2023-09-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
This was referenced Jan 2, 2024
konrad-jamrozik
force-pushed
the
main
branch
from
6f9f31c to
d8e7a99
Compare
JackTn
requested review from
weshaggard,
mikeharder and
konrad-jamrozik
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.