Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suppression test] data factory #3256

Closed
wants to merge 15 commits into from
Closed

[suppression test] data factory #3256

wants to merge 15 commits into from

Conversation

JackTn
Copy link

@JackTn JackTn commented Mar 22, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app-test bot commented Mar 22, 2024

Next Steps to merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has at least one breaking change (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app-test bot commented Mar 22, 2024

Swagger Generation Artifacts

️🔄[ignore this check status; not blocking PR merge] ApiDocPreview inProgress [Detail]
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 49449476e1dd758bbf6fa8e7bc9ff09154d9f778. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • Azure.ResourceManager.DataFactory [Preview SDK Changes]
    info	[Changelog]
  • Azure.ResourceManager.ServiceLinker [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-python failed [Detail]
  • Code Generator Failed in generating from 49449476e1dd758bbf6fa8e7bc9ff09154d9f778. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]  notice
    cmderr	[automation_generate.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
    cmdout	[automation_generate.sh] [Autorest]   | info:  Step: Fetching packages
    cmdout	[automation_generate.sh] [Autorest]   | error: @azure/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.15.0"
    cmdout	[automation_generate.sh] [Autorest]   | error: Found incompatible module.
    cmdout	[automation_generate.sh] [Autorest]   | info: Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmdout	[automation_generate.sh] [Autorest] fatal   | Failed to install extension '@autorest/python' (6.7.1)
    cmdout	[automation_generate.sh] [Autorest]   | info:  Step: Fetching packages
    cmdout	[automation_generate.sh] [Autorest]   | error: @azure/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.15.0"
    cmdout	[automation_generate.sh] [Autorest]   | error: Found incompatible module.
    cmdout	[automation_generate.sh] [Autorest]   | info: Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmdout	[automation_generate.sh] [Autorest] fatal   | Failed to install extension '@autorest/python' (6.7.1)
    cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
    warn	Skip package processing as generation is failed
️❌ azure-sdk-for-java failed [Detail]
  • Failed in generating from 49449476e1dd758bbf6fa8e7bc9ff09154d9f778. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh]  notice
    cmderr	[init.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[init.sh] npm notice
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-datafactory [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-datafactory-1.0.0-beta.29.jar
    • azure-resourcemanager-datafactory-1.0.0-beta.29-sources.jar
  • azure-resourcemanager-servicelinker [Preview SDK Changes]
    • pom.xml
️❌ azure-sdk-for-go failed [Detail]
  • Code Generator Failed in generating from 49449476e1dd758bbf6fa8e7bc9ff09154d9f778. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    cmderr	[generator automation-v2] [ERROR] total 1 error(s):
    cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` 'WARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/servicelinker/armservicelinker
    cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/servicelinker/armservicelinker, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/servicelinker/armservicelinker
    cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/servicelinker/armservicelinker
    cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/servicelinker/armservicelinker
    cmderr	[generator automation-v2] [ERROR] autorest --version=3.8.2 --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/servicelinker/armservicelinker --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
    cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v18.20.2]
    cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
    cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
    cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1).
    cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
    cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.8.2)
    cmderr	[generator automation-v2] [ERROR] error   | [OperationAbortedException] Error occurred. Exiting.
    cmderr	[generator automation-v2] [ERROR] error   |   Error: [OperationAbortedException] Error occurred. Exiting.
    cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmderr	[generator automation-v2] [ERROR] error   | literate/yaml-parsing-error | Syntax Error Encountered:  Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key
    cmderr	[generator automation-v2] [ERROR] - codeBlock_27:11:11
    cmderr	[generator automation-v2] [ERROR] fatal   | Failed to acquire 'require'd configuration 'file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/servicelinker/resource-manager/readme.md'
    cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
    cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
    cmderr	[generator automation-v2] [ERROR] ': exit status 1
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
    warn	Skip package processing as generation is failed
️🔄 azure-sdk-for-js inProgress [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed in generating from 49449476e1dd758bbf6fa8e7bc9ff09154d9f778. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • datafactory/resource-manager [Preview Schema Changes]
  • servicelinker/resource-manager [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 49449476e1dd758bbf6fa8e7bc9ff09154d9f778. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.datafactory.DefaultTag [Preview SDK Changes]
  • ⚠️Az.servicelinker.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app-test bot commented Mar 22, 2024

Generated ApiView

Language Package Name ApiView Link
Java azure-resourcemanager-datafactory Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Swagger Microsoft.DataFactory Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Swagger Microsoft.ServiceLinker https://apiviewstagingtest.com/Assemblies/Review/0f22d5ccf4be40f9abfc7c0cc2e1bbea?revisionId=6b93b53f0a89449ca4370d73b73f9508

Copy link

openapi-pipeline-app-test bot commented Mar 22, 2024

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
servicelinker.json 2022-05-01(34317ed) 2022-05-01(main)
Rule Message
1035 - RemovedOperation The new version is missing an operation that was found in the old version. Was operationId 'Linker_Delete' removed or restructured?
New: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L74:5
Old: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L74:5
Runtime Exception "new":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json",
"old":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/main/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json",
"details":"incompatible properties : properties\n definitions/ManagedIdentityCredentialResource/properties/properties\n at file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7683:8\n definitions/CredentialResource/properties/properties\n at file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7983:8"
Runtime Exception "new":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json",
"old":"https://github.com/test-repo-billy/azure-rest-api-specs/blob/main/specificationRepositoryConfiguration.json",
"details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 20 lines of stack trace follow,
indexed. First line should contain AutoRest command line invocation details. Remaining lines should contain the main message reported by AutoRest.
====================
1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidationTest_1a18ed4f-f3bf-4f34-9fed-13cb57bd2410/0.0.428/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp/oad-kZRswl
2: FATAL: swagger-document/loader - FAILED
3: FATAL: Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')
4: Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')"
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️❌LintDiff: 5 Errors, 0 Warnings failed [Detail] [must fix]The following errors/warnings are introduced by current PR:
Rule Message Related RPC [For API reviewers]
OperationsAPIImplementation Operations API must be implemented for 'Microsoft.DataFactory'.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1
AutoRest exception "tag":"package-2022-05-01",
"details":"[OperationAbortedException] Error occurred. Exiting."
AutoRest exception "tag":"package-2022-05-01",
"details":"!Error: [OperationAbortedException] Error occurred. Exiting."
AutoRest exception "tag":"package-2022-05-01",
"details":"Autorest completed with an error. If you think the error message is unclear,
or is a bug,
please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
AutoRest exception "tag":"package-2022-05-01",
"details":"Syntax Error Encountered: Syntax error: can not read a block mapping entry; a multiline key may not be an implicit key"


The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.

Rule Message
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L316
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L401
GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L421
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L460
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L660
GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L719
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L761
ConsistentPatchProperties The property 'autoUpdate' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L804
ConsistentPatchProperties The property 'updateDelayOffset' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L804
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L914
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L945
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1139
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1145
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1152
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1185
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1191
OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'IntegrationRuntimes' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1382
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1468
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1474
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1777
GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1839
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1881
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1982
GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2044
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2086
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2187
GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2249
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2291
ParametersInPost referencePipelineRunId is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2358
ParametersInPost isRecovery is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2358
️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌Avocado: 13 Errors, 0 Warnings failed [Detail]
Rule Message
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/datafactory/resource-manager/readme.md
json: stable/2018-06-01/examples/Operations_List.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/DeleteLink.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/GetConfigurations.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/Link.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/LinkList.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/OperationsList.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/PatchLink.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/PutLink.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/PutLinkWithServiceEndpoint.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/ValidateLinkFailure.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: preview/2021-11-01-preview/examples/ValidateLinkSuccess.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/servicelinker/resource-manager/readme.md
json: Microsoft.ServiceLinker/preview/2021-11-01-preview/servicelinker.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/servicelinker/resource-manager/readme.md
json: stable/2022-05-01/examples/DeleteLink.json
️❌ModelValidation: 87 Errors, 0 Warnings failed [Detail] Only 30 items are listed, please refer to log for more details.
Rule Message
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1132:22
ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Start.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1181:22
ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Stop.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1461:22
ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L46:35
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L56:36
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L50:47
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L51:45
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L60:47
INVALID_TYPE Expected type object but found type array
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L124:31
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L134:32
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L128:43
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L129:41
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L138:43
INVALID_TYPE Expected type object but found type array
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L112:31
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L122:32
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L116:43
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L117:41
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L126:43
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L47:31
INVALID_TYPE Expected type object but found type array
Url: stable/2018-06-01/entityTypes/Pipeline.json#L163:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L57:32
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L51:43
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L52:41
INVALID_TYPE Expected type object but found type string
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L61:43
INVALID_TYPE Expected type object but found type array
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5693:31
ExampleUrl: stable/2018-06-01/examples/Pipelines_CreateRun.json#L8:19
INVALID_TYPE Expected type object but found type array
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6618:31
ExampleUrl: stable/2018-06-01/examples/PipelineRuns_QueryByFactory.json#L48:28
INVALID_TYPE Expected type object but found type array
Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6618:31
ExampleUrl: stable/2018-06-01/examples/PipelineRuns_QueryByFactory.json#L69:28
️❌SemanticValidation: 8 Errors, 0 Warnings failed [Detail]
Rule Message
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: swagger
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: info
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: paths
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: $schema
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: pipelineName
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sdkRepositoryMappings
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: overrides
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: typespecEmitterToSdkRepositoryMapping
JsonUrl: azure-rest-api-specs/blob/34317edabeb393a5161b00ffda2f90d9ed2a0330/specificationRepositoryConfiguration.json
️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@JackTn JackTn closed this Apr 24, 2024
@JackTn JackTn reopened this Apr 24, 2024
@JackTn JackTn closed this Oct 25, 2024
@JackTn JackTn deleted the jacktn/bug-suppressions branch October 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants