-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
networks are not automatically removed #2
Comments
Reported as docker/compose#6636 |
@bsideup any updates on that? I think I've just encountered this issue and the corresponding docker compose ticket is closed |
I'm looking into this at the moment; I suspect the most straightforward path is to upgrade the version of docker-compose that we use to at least support v2.1 compose files. Will have a try with that approach first. |
…ge pull Together with using Compose file 2.1 syntax, this is a solution to network cleanup issue described in: * #1767 * #739 * testcontainers/moby-ryuk#2 * docker/compose#6636 Solution to general credential helper authenticated pull issues in: * docker/compose#5854 Tangentially should add support for v3 syntax (not yet tested) re #531
* Upgrade docker-compose image to latest version and perform direct image pull Together with using Compose file 2.1 syntax, this is a solution to network cleanup issue described in: * #1767 * #739 * testcontainers/moby-ryuk#2 * docker/compose#6636 Solution to general credential helper authenticated pull issues in: * docker/compose#5854 Tangentially should add support for v3 syntax (not yet tested) re #531
This should have been resolved in #1847, with an upgrade to the version of docker compose in use. Release notes here: https://github.com/testcontainers/testcontainers-java/releases/tag/1.12.4 |
I am running a docker compose with testcontainers. But I do not explicitly stop the DockerComposeContainer at the end of my test (because the container is statically reused by multiple test in the test suite). I was expecting the moby-ryuk to delete the containers and the networks at the end. It actually does delete the container correctly, but it does not seem to delete the networks.
Is this the expected behavior? I was under the impression that the ryuk was meant exactly for this purpose...
The text was updated successfully, but these errors were encountered: