-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove binding of ports to IPv4 only #1363
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Could this possibly have caused the problem described here to re-occur? We run a fake SMTP Server in a docker container. The system-under-test connects to the SMTP port to send emails. The ports are configured using We've not modified this code in the last few months; it used to work reliably. Of course, this being a timing/concurrency issue, it's entirely likely that the root cause has existed in the beginning, and only the execution timing has shifted recently. |
@BrunoJuchli Which container runtime do you use? |
@HofmeisterAn
We're running this on GitHub Action - Ubuntu-latest. If the info above doesn't make it obvious to you on first sight what container runtime is used, I'm happy to dig deeper. |
I assume you're encountering a different issue. I think the issue you're referring to is related to environments running Docker Desktop. I haven't noticed any flakiness in our CI pipeline (we're using GH-hosted runners too, though we use Ubuntu 22.04). Have you been using 24.04 for a while? I believe there were some issues with the runners in general, if I'm not mistaken. |
@HofmeisterAn I've executed some test runs with Ubuntu 24 and Ubuntu 22. Since our tests are quite long-running, the sample size isn't large - and the conclusion not a 100% reliable, but:
From previous runs I see that close to half of the test runs on Ubuntu 24 in recent days failed. So having 6 test runs on Ubuntu 22 pass looks like a reliable enough indicator to me. |
For reference, we have encountered some issues with the VM images in the past (anyone that depends on Docker) due to incompatible kernel versions. I do not know the exact details, but you can find more information about those issues here:
It might be a good idea to start running our tests against version 24.04 as well, to see if there are any issues we can address or information we need to provide to the upstream: GitHub Actions Runner Images. |
What does this PR do?
Removes the HostIP from the Port Binding so that it does not restrict itself to IPv4.
Why is it important?
Not needed anymore.
Related issues