-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: building blocks for Go modules #1016
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
a236e33
to
9059f5a
Compare
It will allow providing access to the underlying Logger, the container Provider, the Started and Reuse states
Kudos, SonarCloud Quality Gate passed!
|
@@ -3,19 +3,10 @@ package neo4j | |||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fbiville please take a look at these changes, as the NeoJ module will be refactored after this PR
@@ -3,9 +3,10 @@ package vault | |||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alihanyalcin please take a look at these changes, as the Vault module will be refactored after this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, couchbase won't be modified, as it comes with some postStart "hooks" (initCluster and create buckets), and the container request is not providing those capabilities yet. Possibly in upcoming releases
What does this PR do?
This PR adds certain building blocks that will support the creation of new modules, and the migration of old examples to modules. For that:
CustomizeRequestOption
type which will be used in modules as a functional opt to customize the initial container request.Why is it important?
Simplify the experience writing modules, preparing for the new Go design.