-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add grafana-lgtm module #2660
Merged
mdelapenya
merged 11 commits into
testcontainers:main
from
mdelapenya:grafana-lgtm-module
Aug 5, 2024
Merged
feat: add grafana-lgtm module #2660
mdelapenya
merged 11 commits into
testcontainers:main
from
mdelapenya:grafana-lgtm-module
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
added a commit
that referenced
this pull request
Aug 5, 2024
* main: feat: add grafana-lgtm module (#2660) Added valkey module (#2639) fix: container.Endpoint and wait.FortHTTP to use lowest internal port (#2641) chore: test cleanups (#2657) docs: fix compilation of examples (#2656) feat: add custom container registry substitutor (#2647) fix: couchbase containers intermittently hang on startup (#2650) chore(deps): bump Ryuk to 0.8.1 (#2648) fix: retry on label error (#2644) perf: optimise docker authentication config lookup (#2646)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 6, 2024
* main: chore: print Docker Info labels in banner (testcontainers#2681) fix: incorrect parsing of exposedPorts in readiness check (testcontainers#2658) feat: add grafana-lgtm module (testcontainers#2660) Added valkey module (testcontainers#2639) fix: container.Endpoint and wait.FortHTTP to use lowest internal port (testcontainers#2641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new module for the Grafana LGTM docker container, which contains a single container to collect logs, traces and metrics thanks to an Otel Collector, Tempo, Loki and Prometheus, all into the single container.
The module exposes methods to get the endpoints for all the services in the format
<host>:<port>
, so please configure your clients accordingly (e.g. adding the http schema if/when needed).The module also exposes an optional configuration for the admin credentials, in case you need to update the default
admin/admin
credentials, that the system forces you to update for first time. Passing credentials makes you access the system without updating the password.The testable example code was taken from https://github.com/grafana/docker-otel-lgtm/tree/main/examples/go, which is also used in the otel go sdk: https://opentelemetry.io/docs/languages/go/getting-started/
Why is it important?
With this module, it's super helpful to verify your observability story is able to send Otel data to an otel collector.