Override localstack image using TestcontainersConfiguration

[wavetylor]

Currently using the Localstack module is not possible in a situation where pulling public docker images is not possible.

Testcontainer has a facility to address this, testcontainer.properties, but localstack doesn't take advantage of this.

It would be excellent if this were the case!

[rnorth]

Hi @wavetylor. Sure! I think this would be fine.

If you'd like to raise a PR that would be great. I don't think there should be any serious gotchas.

The only thing is that the tag/version part probably belongs in the testcontainers.properties override (i.e. you'd use the no-args constructor), but I expect that was probably your plan anyway.

Please have a glance over any Localstack related issues/PRs we have (e.g. #1504) so that you can get a sense of other forthcoming changes - not because it impacts this change directly, but more so you can be confident that we'll remain compatible with your custom image!

[wavetylor]

@rnorth sounds good. Already working on the changes.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

[eddumelendez]

Nowadays, testcontainers support image name substitution which solves issues like this.

@wavetylor feel free to reopen if I missed something.