Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring the docker-compose executable path #306

Closed
jooola opened this issue Feb 9, 2023 · 1 comment · Fixed by #512
Closed

Allow configuring the docker-compose executable path #306

jooola opened this issue Feb 9, 2023 · 1 comment · Fixed by #512
Labels
✅ close on merge Issue that will be closed by an open pull request 🚀 enhancement 👀 requires attention

Comments

@jooola
Copy link

jooola commented Feb 9, 2023

Describe the bug

On newer docker setups, docker-compose is part of docker under a docker sub commands: docker compose

This makes this library fail to find docker-compose when needed.

For now I have a little script but I expect this library to be able to change the executable name:

#!/usr/bin/env bash

exec docker compose "$@"
@jooola jooola added the 🐛 bug label Feb 9, 2023
@jooola jooola mentioned this issue Feb 10, 2023
Closed
@tillahoffmann tillahoffmann added 🚀 enhancement ✅ close on merge Issue that will be closed by an open pull request and removed 🐛 bug 👀 requires attention labels Feb 16, 2023
@tillahoffmann tillahoffmann linked a pull request Feb 16, 2023 that will close this issue
Update compose to work with both "docker-compose" as well as "docker compose" #254
Closed
@jhnnsrs jhnnsrs mentioned this issue Feb 24, 2023
Closed
@psschwei psschwei mentioned this issue Jun 5, 2023
Closed
@carlosemart carlosemart mentioned this issue Dec 5, 2023
Closed
@alexanderankin
Copy link
Member

linking #358

alexanderankin added a commit to alexanderankin/testcontainers-python that referenced this issue Feb 20, 2024
@alexanderankin
propose compose implementation re: testcontainers#306, testcontainers…
b8dc0cf 
…#358
@alexanderankin alexanderankin mentioned this issue Feb 20, 2024
Merged
alexanderankin added a commit that referenced this issue Mar 6, 2024
@alexanderankin
feat(compose)!: implement compose v2 with improved typing (#426)
5356caf 
relates to #306, #358
alexanderankin added a commit that referenced this issue Mar 29, 2024
@alexanderankin
fix #306
d5b63e4
@alexanderankin alexanderankin mentioned this issue Mar 29, 2024
Merged
alexanderankin added a commit that referenced this issue Mar 29, 2024
@alexanderankin
fix(core): allow setting docker command path for docker compose (#512)
63fcd52 
fix #306

the original request was to remedy tc-python's dependency on
docker-compose.

this is something totally different but its what was asked for, so oh
well. ¯\_(ツ)_/¯.
bearrito pushed a commit to bearrito/testcontainers-python that referenced this issue Mar 30, 2024
@alexanderankin
fix(core): allow setting docker command path for docker compose (test…
95100a3 
…containers#512)

fix testcontainers#306

the original request was to remedy tc-python's dependency on
docker-compose.

this is something totally different but its what was asked for, so oh
well. ¯\_(ツ)_/¯.
@benmoss benmoss mentioned this issue Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✅ close on merge Issue that will be closed by an open pull request 🚀 enhancement 👀 requires attention
Projects
None yet
Milestone
No milestone
3 participants
@tillahoffmann @alexanderankin @jooola