Integrate poetry into devcontainers #431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions here - #430
As well as looking at recent changes. It seems as though the devcontainer workflow is broken.
This PR will get you a working(?) install.
From within the container
Core tests passed.
However, some module based tests seemed to fail. Seems like this a known issue though - #428
Their is small downside to this. Poetry is installed as part of the post-create-command, which means everytime the container is spawned poetry has to be installed. This takes about 30 seconds. It is feasible to build another image inside devcontainers. However, that differs from current workflow. Let me know.