-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages #1185
base: main
Are you sure you want to change the base?
Improve error messages #1185
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 56dd0e4:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the changes are not fully covered by tests.
Can you structure this PR into multiple commits that make it easier to spot how error messages were changed (e.g. one commit with new tests and existing behavior and the next commit with changed behavior and updated tests)?
Hey, I did not finish (this is why I haven't checked the ready to merge checkbox) 😄 |
@eps1lon for some reason the tests fail on the snapshots are the same also, how do you want me to organize my changes? |
@eps1lon tagging you again in case you missed that |
What: Improve the error messages
Why: #732
How: updated the
getMultipleError
,getMissingError
Checklist:
docs site
Now, for custom matchers functions we would use the:
customMatcherText
property on the function[anonymous function]