-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run against ESLint v9 #926
Conversation
cea93a4
to
64745f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
+ Coverage 96.23% 96.33% +0.09%
==========================================
Files 44 46 +2
Lines 2419 2481 +62
Branches 1000 1028 +28
==========================================
+ Hits 2328 2390 +62
Misses 91 91 ☔ View full report in Codecov by Sentry. |
41baf4e
to
aeda1af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, but I'll give it another review after being rebased.
f8a8bfb
to
1e22221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor tweaks to the comments to make them consistent all over the place, but nothing big
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
eslint-plugin-jest
,eslint-plugin-jest-dom
, andeslint-plugin-jest-extended
with great successfulContext
Before saying the plugin officially supports ESLint v9, it should be testing against v9 which in turn requires accounting for v9's defaulting to flat config and the improvements that have been made to the rule tester to help plugin authors catch bugs.
Besides flat config in general, the two notable changes to the rule tester that require changes to this test suite are:
output
that matchescode
There's only a couple of occurrences of that first one and the fix is to just specify
null
instead which means "this rule supports autofix, but for this test case it does not do anything".The second though requires a lot more work especially because of how much mapping this test suite does meaning addressing them in full would have huge changes to the layout so instead for now I've made all the tests unique typically by adding a comment that mentions the testing framework whose loop they're part of - ideally though a number of these tests should be restructured to pull such cases out of the mapping loops, which is something I'm happy to help with via follow-up and parallel PRs.
I have also cherry-picked the straightforward removal of a number of duplicates into #927 which if landed first would help reduce the overall diff of this pull request.