-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update complex example #806
docs: update complex example #806
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d323661:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
@all-contributors please add @lidoravitan for docs |
I've put up a pull request to add @lidoravitan! 🎉 |
@kentcdodds It looks like the build failed for |
Node 15 messed things up with npx: npm/cli#1935 I think we should just get rid of |
Cool, wasn't aware of that even happening, thanks! |
Yeah. I'm not sure why we'd need to test on node 15 🤷♂️ |
I mean, I understand that it could help us address breaking changes in the future, but it's unlikely that will be a problem for us to solve anyway. |
What would be even better is if a failure of |
🎉 This PR is included in version 11.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
I update README.md complex example section. So, the test will be valid.
Why:
How:
I added the missing variable and fixed the promise to reject in case of
200<
status code.Checklist:
docs site - N/A