Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #460 #487

Closed
wants to merge 3 commits into from
Closed

Fix #460 #487

wants to merge 3 commits into from

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Nov 10, 2020

What:

Fixes #460

Why/How:

Cloned from yshwaker/user-event and implemented #460 (comment)

Checklist:

  • Documentation N/A
  • Tests
  • Typings N/A
  • Ready to be merged

yshwaker and others added 2 commits October 2, 2020 15:48
should only call setSelectionRange if the activeElement did not change
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. A test would be welcome 👍

@nickserv

This comment has been minimized.

@kentcdodds

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #487 (a9592b6) into master (a28d338) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #487    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           13        13            
  Lines          615       493   -122     
  Branches       200       136    -64     
==========================================
- Hits           615       493   -122     
Impacted Files Coverage Δ
src/type.js 100.00% <100.00%> (ø)
src/tab.js 100.00% <0.00%> (ø)
src/blur.js 100.00% <0.00%> (ø)
src/clear.js 100.00% <0.00%> (ø)
src/click.js 100.00% <0.00%> (ø)
src/focus.js 100.00% <0.00%> (ø)
src/hover.js 100.00% <0.00%> (ø)
src/paste.js 100.00% <0.00%> (ø)
src/utils.js 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a28d338...b9ced6c. Read the comment docs.

@ph-fritsche ph-fritsche mentioned this pull request Dec 14, 2020
8 tasks
@ph-fritsche
Copy link
Member

Resolved in v13.0.0 🚀

@MichaelDeBoey MichaelDeBoey deleted the fix-460 branch May 16, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show warning when using userevent.type and blur()
4 participants