Remove unused contains_absolute_symlinks from LinkFarm

tests/helpers/mod.rs

@@ -67,15 +67,13 @@ fn cwd() -> &'static Cwd {
 pub struct LinkFarm {
     cwd: &'static Cwd,
     tempdir: TempDir,
-    contains_absolute_symlinks: bool,
 }
 
 impl LinkFarm {
     pub fn new() -> Self {
         Self {
             cwd: cwd(),
             tempdir: tempdir().unwrap(),
-            contains_absolute_symlinks: false,
         }
     }
 
@@ -150,13 +148,7 @@ impl LinkFarm {
 
     // create symlink to absolute path in link farm
     // note the reversed order of parameters
-    //
-    // also record that the farm now contains absolute symlinks
-    pub fn symlink_abs<P: AsRef<Path>, Q: AsRef<Path>>(
-        &mut self,
-        link: P,
-        original: Q,
-    ) -> &mut Self {
+    pub fn symlink_abs<P: AsRef<Path>, Q: AsRef<Path>>(&self, link: P, original: Q) -> &Self {
         let original = self.tempdir.path().join(original);
         let link = self.tempdir.path().join(link);
         if link.is_dir() {
@@ -165,8 +157,6 @@ impl LinkFarm {
             symlink_file(original, link).unwrap()
         }
 
-        self.contains_absolute_symlinks = true;
-
         self
     }
 

tests/path_ext.rs

@@ -143,15 +143,14 @@ fn test_real_parent_rel_indirect_symlinks_not_windows(path: &str, expected: &str
 #[test_case("A/B/=a1", "A")]
 #[test_case("A/B/=C", "A")]
 fn test_real_parent_abs_symlinks(path: &str, expected: &str) {
-    let mut farm = LinkFarm::new();
+    let farm = LinkFarm::new();
 
     farm.dir("A")
         .dir("A/B")
         .dir("A/C")
         .file("A/B/b1")
-        .file("A/a1");
-
-    farm.symlink_abs("A/B/=b1", "A/B/b1")
+        .file("A/a1")
+        .symlink_abs("A/B/=b1", "A/B/b1")
         .symlink_abs("A/B/=a1", "A/a1")
         .symlink_abs("A/B/=C", "A/C");
 
@@ -341,15 +340,14 @@ fn test_is_real_root_not_rel_indirect_symlinks_not_windows(path: &str) {
 #[test_case("A/B/=C")]
 #[cfg(not(target_family = "windows"))]
 fn test_is_real_root_not_abs_symlinks_not_windows(path: &str) {
-    let mut farm = LinkFarm::new();
+    let farm = LinkFarm::new();
 
     farm.dir("A")
         .dir("A/B")
         .dir("A/C")
         .file("A/B/b1")
-        .file("A/a1");
-
-    farm.symlink_abs("A/B/=b1", "A/B/b1")
+        .file("A/a1")
+        .symlink_abs("A/B/=b1", "A/B/b1")
         .symlink_abs("A/B/=a1", "A/a1")
         .symlink_abs("A/B/=C", "A/C");