Panics caller on exit error #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to backfill some unit tests so that we don't have this happen again. |
anuraaga
reviewed
Jul 5, 2022
|
next step: test wasi with rust to verify the exit code zero thing.. then polish (a couple missing tests and RATIONALE) |
codefromthecrypt
force-pushed
the
panic-on-close
branch
from
ed8b9b3 to
f7e4418
Compare
|
ok leaving out a rust variant of wasi as it is massive and uses wasi-libc which the other example in this PR already does. |
codefromthecrypt
commented
Jul 6, 2022
This changes the AssemblyScript abort handler and WASI proc_exit implementation to panic the caller which eventually invoked close. This ensures no code executes afterwards, For example, LLVM inserts unreachable instructions after calls to exit. See emscripten-core/emscripten#12322 See #601 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
panic-on-close
branch
from
cb54ba3 to
16b6ccc
Compare
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Jul 6, 2022
codefromthecrypt
commented
Jul 6, 2022
Signed-off-by: Adrian Cole <[email protected]>
|
thanks for the help @anuraaga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the AssemblyScript abort handler and WASI proc_exit
implementation to panic the caller which eventually invoked close.
This ensures no code executes afterwards, For example, LLVM inserts
unreachable instructions after calls to exit.
See emscripten-core/emscripten#12322
See #601