Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME Update requires .NET Framework 3.5 - error handling #63

Closed
datagutten opened this issue May 22, 2018 · 5 comments
Closed

ME Update requires .NET Framework 3.5 - error handling #63

datagutten opened this issue May 22, 2018 · 5 comments
Labels

Comments

@datagutten
Copy link
Contributor

When I run BiosSledgehammer on a fresh install of Windows 10 on a 640 G1 or 840 G4 I get a popup asking me to install .NET Framework 3.5 during the ME upgrade step.
The upgrade returns a non-zero exit code, but BiosSledgehammer does not detect it and tells me that the upgrade has succeeded and that I should restart the computer.
I am not sure if it is the detection tool or the upgrade itself that requires .NET, but I will examine that further tomorrow.

@texhex
Copy link
Owner

texhex commented May 22, 2018

This is clearly an issue on my side, hence in BiosSledgehammer.ps1. So far, the return code is not checked so any "non fatal" exist is considered success.

As I imagine that those devices should return to users rather quick, I created a patch so the ME update uses the same logic as for BIOS updates, where only 0 or 3010 are considered successful execution.

@texhex
Copy link
Owner

texhex commented May 22, 2018

You could test this new version (4.0.7) with that device to see if now an error is thrown if .NET 3 is not installed. Please note, this code is untested so far (but given that it works for BIOS updates, it should work).

As a side note: That newer ME updates require .NET 3 is noted in the docs.

@texhex texhex added the bug label May 22, 2018
@texhex
Copy link
Owner

texhex commented Jun 5, 2018

@datagutten Did you had the chance to give the new code a test run?

@datagutten
Copy link
Contributor Author

I have tested it once, and it worked, but I will do some more testing to see that it is stable.

@texhex
Copy link
Owner

texhex commented Jul 4, 2018

I was able to grab a test device on Monday, removed .NET and an error was generated for the ME update. The fix is live with v4.0.7 so I'm closing this issue.

Please feel free to open it again if any future tests on your side show this is not fully fixed.

@texhex texhex closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants